Cleanup the blosc testing in nc_test4 and nczarr_test. #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Issue Unidata#2868 There are three parameters (zero, one, and two) that are currently used in testing, but should not be. Parameters zero and one are ignored by the code and parameter two is the typesize parameter that either takes on the value 0 or 4 (== sizeof(int)). See nc_test4/tst_specific_filters.sh. Unfortunately, these three parameters differ depending on the blosc library. The solution is to force them to a specific value -- namely 0,0,0 -- in the test script.
WardF
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Issue #2868
There are three parameters (zero, one, and two) that are currently used in testing, but should not be. Parameters zero and one are ignored by the code and parameter two is the typesize parameter that either takes on the value 0 or 4 (== sizeof(int)).
See nc_test4/tst_specific_filters.sh.
Unfortunately, these three parameters differ depending on the blosc library.
The solution is to force them to a specific value -- namely 0,0,0 -- in the test script.