Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing to create SUMMA input #142

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
include pysumma/meta/*
include pysumma/calibration/meta/*
include pysumma/preprocessing/meta/*
include versioneer.py
include pysumma/_version.py
include LICENSE
4 changes: 4 additions & 0 deletions pysumma/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
from .force_file_list import ForcingList
from . import utils
from .calibration import Ostrich, OstrichParam
from . import hydroshare_utils
from .preprocessing import LocalAttributes, InitialCondition, ParamTrial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to have these not only live in preprocessing but be more general classes which act as interfaces to these methods. Then we could do something like LocalAttributes.from_netcdf(filepath) or LocalAttributes.from_tif(filepath) which might end up being a bit cleaner. Let's also make sure these follow the conventions in the FileManager class, so we should update ParamTrial -> TrialParams

from .preprocessing import gis_code
from .preprocessing import input_netcdf

from ._version import get_versions
__version__ = get_versions()['version']
Expand Down
246 changes: 0 additions & 246 deletions pysumma/preprocess_csv.py

This file was deleted.

5 changes: 5 additions & 0 deletions pysumma/preprocessing/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from .create_initial_condition import InitialCondition
from .create_local_attribute import LocalAttributes
from .create_param_trial import ParamTrial
from .input_netcdf import *
from .gis_code import *
Loading