-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocessing to create SUMMA input #142
Open
DavidChoi76
wants to merge
8
commits into
UW-Hydro:develop
Choose a base branch
from
DavidChoi76:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
846344c
Merge pull request #4 from UW-Hydro/develop
9e7c497
add preprocessing modules
b22f704
don't need specworker anymore on CJH
74c18da
add preprocessing modules
c0ee637
move this function to preprocessing folder
315fc4a
add meta folder in preprocessing folder
4528aaa
edit values of heightCanopy Top and Bottom
52a463d
change the default value of soil depth to make the same number soil l…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
include pysumma/meta/* | ||
include pysumma/calibration/meta/* | ||
include pysumma/preprocessing/meta/* | ||
include versioneer.py | ||
include pysumma/_version.py | ||
include LICENSE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
from .create_initial_condition import InitialCondition | ||
from .create_local_attribute import LocalAttributes | ||
from .create_param_trial import ParamTrial | ||
from .input_netcdf import * | ||
from .gis_code import * |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be good to have these not only live in
preprocessing
but be more general classes which act as interfaces to these methods. Then we could do something likeLocalAttributes.from_netcdf(filepath)
orLocalAttributes.from_tif(filepath)
which might end up being a bit cleaner. Let's also make sure these follow the conventions in theFileManager
class, so we should updateParamTrial
->TrialParams