Fixes for changes to downloadable data and "calendar" missing #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloaded runoff (and other) data are now missing the "calendar" attribute for the time variable. This fix uses the default calendar specified in the config file if that's missing and emits a warning. Also adds mm/day as an acceptable unit. Both were causing crashes in current use.
|
Hi all, I realized that I may have been conflating two development teams with this patch. I'm assisting a team working with this model (https://www.sciencebase.gov/catalog/item/5b170442e4b092d9651fcc93) that uses RVIC. Their workflow downloads climate data from a UC Berkeley server - that server's data has no calendar attribute for the Time variable in the NetCDF files - in our case, using the default calendar seemed sensible, but if that's not sensible for RVIC core, then feel free to reject this - I also wasn't sure if adding mm/day under mm for units was appropriate, but it made sense for our case. Hope that helps provide some context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloaded runoff (and other) data are now missing the "calendar" attribute for the time variable. This fix uses the default calendar specified in the config file if that's missing and emits a warning.
Also adds mm/day as an acceptable unit. Both were causing crashes in current use.