Improve hostname detection #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, @michaelmayer2! Without having done a review yet, I wonder if there's a way of doing this optional, i.e., what happens if (even if unlikely) Python is not loaded? Furthermore, I'd try to wrap the call using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the hostnames allocated to a SLURM job launched by
slurmRare detected via runningsrun hostnameand then browsing SLURM stdout of the resulting job. This works for many cases but also can be error prone if thesruncommand is returning more than just the hostname.The patch in this PR is using a tool called python-hostlist to programmatically determine the hostnames from the
scontrol show joboutput.Curious to see/hear if this PR makes sense or not.