Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate stretch parameter into cloth max segment length calculation #41

Open
dcolli23 opened this issue Nov 16, 2022 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dcolli23
Copy link
Contributor

Need to incorporate the stretch parameter (lambda in the paper) into the cloth max segment length calculation.

Additionally, I'm not sure that taking the minimum of the grid lengths is appropriate. I think it logically should be the maximum length.

Code in question:

ClothConfiguration::ClothConfiguration(float const length_initial, float const width_initial,
    float const grid_size_initial_guess)
    ...
{
    ...
    max_segment_length_ = std::min({grid_size_initial_actual_length,
        grid_size_initial_actual_width});
}

where ... indicates omitted lines.

@dcolli23 dcolli23 added bug Something isn't working good first issue Good for newcomers labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant