ROD-138 Add logic to hide information if user selects they are a sponsor #62
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| parse: d => d && dateFormater.format(new Date(d)) | ||
| parse: (d, req) => { | ||
| const isSponsor = req.sessionModel.get('who-is-completing') === 'sponsor'; | ||
| return !isSponsor && d ? dateFormater.format(new Date(d)) : null; |
There was a problem hiding this comment.
Even if we select the sponsor, we still present this page and users have to enter date of application. Any specific requirement to hide this ?
| field: 'cancel-application', | ||
| parse: (value, req) => { | ||
| const isSponsor = req.sessionModel.get('who-is-completing') === 'sponsor'; | ||
| return !isSponsor ? value : null; |
There was a problem hiding this comment.
I don't think we need this change. If cancel application options are not presented, these should not be visible by default. Please validate this on the existing branch testing URL for ROD-122
|
Also, since other changes from ROD-122 are not available in this branch, we cannot validate the changes using this branch URL. If we need any changes, then they should be made in the existing PR - #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
ROD-138 - Date of submission and Cancelling application? should not appear if the person completing the form is a sponsor.
Why?
How?
Testing?
Tested on local machine
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit