Grader feedback fix #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddob
requested changes
Jun 19, 2020
| @@ -145,6 +145,7 @@ def save_additional_form_fields(params) | |||
| if assessment.is_section_dependant | |||
| form_hash["section"] = (assessment.lecture?) ? course_user_datum.lecture : course_user_datum.section | |||
| end | |||
| form_hash["ip"] = self.submitter_ip | |||
There was a problem hiding this comment.
This change is part of a separate change that has been merged - it should not be included here
| @@ -6,7 +6,7 @@ | |||
| <%= @score.feedback %> | |||
| Score for this problem: <%= @score.score.to_f().round(1) %> | |||
|
|
|||
| Graded by: <%= if @score.grader && @score.grader.user then @score.grader.user.email end %> | |||
| Graded by: <%= if @score.grader && @score.grader.user then @score.grader.user.email elsif @assessment.has_autograder? then "Autograder" end %> | |||
There was a problem hiding this comment.
There are other places this needs to be resolved as well - for example:
Autolab/app/views/scores/_score.html.erb
Line 10 in c7cb238
Autolab/app/views/scores/show.html.erb
Line 10 in c7cb238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.