Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make types dir inside src folder & clean some misunderstood commas #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dorlevy1
Copy link

Hey,
I added a folder for managing the types to make the code more organized.
Let me know if this is needed, and if so, I'll continue organizing the rest accordingly!

@dorlevy1
Copy link
Author

and i also added to the gitignore the .idea folder from the webstorm ide

@dorlevy1
Copy link
Author

if you indeed want this

###please do not merge the pull###

i also need the add the babel-plugin-module-resolver --save to package.json
and continue to make all the types

@Tynopia
Copy link
Owner

Tynopia commented Nov 10, 2024

Hey, thanks for your PR!
The code is now split across multiple files. When building, though, are the types being bundled back into a single file like index.d.ts?

@dorlevy1
Copy link
Author

dorlevy1 commented Nov 14, 2024

Yes, absolutely. If the types don’t change frequently, we can always bundle them back into index.d.ts using Babel or Webpack (and I believe Babel alone can handle this as well).

Please let me know if you want me to proceed with this or hold off for now.

-- update --
** just tested it with a build, and it does indeed bundle everything back into the index.d.ts file! **

@dorlevy1
Copy link
Author

image

@dorlevy1
Copy link
Author

@Tynopia Done for the types

@dorlevy1
Copy link
Author

dorlevy1 commented Nov 17, 2024

also fixed the lint tests , as i know , we dont need the package-lock.json no?
or am i wrong and i will add it again

@dorlevy1
Copy link
Author

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants