Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bundling issues relating to @turf/jsts in buffer module #2501

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

JamesLMilner
Copy link
Collaborator

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Aims to resolve #2498 - this according to users who have patched using this approach this should resolve bundling issues relating to importing @turf/jsts

Copy link
Collaborator

@twelch twelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My sense is the downstream issue for ESM users is that it won't let you access named exports directly in the import statement. You have to break it up. I'm surprised this issue isn't popping up elsewhere?

@JamesLMilner JamesLMilner merged commit b0fc70c into master Sep 28, 2023
3 checks passed
@abettermap
Copy link

@JamesLMilner thanks for fixing this! How would I go about installing it? I do not see a Git tag for v7.0.0-alpha.2 yet. @twelch do you intend to add one, or should I approach the install differently?

@twelch
Copy link
Collaborator

twelch commented Sep 29, 2023

@abettermap it's not released yet to npm. Check back in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: Named export 'BufferOp' not found
3 participants