This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Girish sarbhukan feat/modal component updated #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'feat/modal-component-updated' of https://github.com/GirishSarbhukan/octagon into GirishSarbhukan-feat/modal-component-updated
|
We have closed an existing PR for modal component i.e. #359 due to new commit changes are not getting reflected in the commit for this PR also as per Bob's last comment build was not working. Andrew helped us to resolve the issue with PR and committed the changes. With this commit we have created a new PR as #361 Could you please review once and approve the same for closure. |
|
Woohoo! new surge deployment available for viewing! 🎉 surgereviewwyulatwqckdaenk.surge.sh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new PR due to new commit changes are not reflecting in the commit.
Modal implementation as per new UX design, this includes:
1.2 Desktop HD Modal - Medium - Completed
1.3 Desktop HD Modal - Large - Completed
1.4 Desktop HD Modal - Lines - Completed
1.5 Desktop HD Modal - Lines Anatomy - Completed
1.6 Desktop HD Information - Information - Completed
1.7 Desktop HD Information - Success - Completed
1.8 Desktop HD Information - Warning - Completed
1.9 Desktop HD Information - Error - Completed
1.10 Desktop HD Confirmation - Information - Completed
1.11 Desktop HD Confirmation - Success - Completed
1.12 Desktop HD Confirmation - Warning - Completed
1.13 Desktop HD Confirmation - Error - Completed
1.14 Desktop HD Modal - Medium - Form Elements - Pending (Yet to start)
1.15 Desktop HD Modal - Large - Form Elements - Pending (Yet to start)
As we already provided several examples above for modal dialog, so one can refer the same and create form dialog as per application requirement.
Do we really need to create Dialog form example's for 1.14 and 1.15?]
UX Link for modal: https://preview.uxpin.com/619354439db88fff063bd90d160a2fab12b973f4#/pages/95670578/specification/sitemap?mode=i
**Existing closed PR ** :#359
Providing screen shots for reference:
