Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

used a docker image with nodejs12 and aws-sam-cli installed; #15

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM nikolaik/python-nodejs:python3.8-nodejs12-alpine
FROM https://registry.hub.docker.com/r/vukomir/aws-sam-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the full url, vukomir/aws-sam-cli:latest should suffice

Copy link
Author

@aprilmintacpineda aprilmintacpineda Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, sorry about that part! I will correct this in a while...


ENV SAM_CLI_TELEMETRY 0

Expand Down
20 changes: 0 additions & 20 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,6 @@ function parseInputs(){
fi
}

function installAwsSam(){
echo "Install aws-sam-cli ${INPUT_SAM_VERSION}"
if [ "${INPUT_SAM_VERSION}" == "latest" ]; then
pip install aws-sam-cli >/dev/null 2>&1
if [ "${?}" -ne 0 ]; then
echo "Failed to install aws-sam-cli ${INPUT_SAM_VERSION}"
else
echo "Successful install aws-sam-cli ${INPUT_SAM_VERSION}"
fi
else
pip install aws-sam-cli==${INPUT_SAM_VERSION} >/dev/null 2>&1
if [ "${?}" -ne 0 ]; then
echo "Failed to install aws-sam-cli ${INPUT_SAM_VERSION}"
else
echo "Successful install aws-sam-cli ${INPUT_SAM_VERSION}"
fi
fi
}

function runSam(){
if [ "${INPUT_GITHUB_PACKAGE_REGISTRY_TOKEN}" == "" ]; then
echo "//npm.pkg.github.com/:_authToken=${INPUT_GITHUB_PACKAGE_REGISTRY_TOKEN}" > ~/.npmrc
Expand Down Expand Up @@ -83,7 +64,6 @@ function gotoDirectory(){

function main(){
parseInputs
installAwsSam
gotoDirectory
runSam
}
Expand Down