feat: add more spawn options

@tracerbench/message-transport/package.json

@@ -7,6 +7,7 @@
     "index.d.ts"
   ],
   "types": "index.d.ts",
+  "main": "index.js",
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^3.0.2",
     "@typescript-eslint/parser": "^3.0.2",

@tracerbench/protocol-connection/src/index.ts

@@ -1,10 +1,12 @@
-import type { AttachMessageTransport } from "@tracerbench/message-transport";
-import newAttachProtocolTransport, {
-  DebugCallback,
-} from "@tracerbench/protocol-transport";
-import type { RaceCancellation } from "race-cancellation";
+import newAttachProtocolTransport from "@tracerbench/protocol-transport";
 
-import type { EventEmitter, RootConnection } from "../types";
+import type {
+  AttachMessageTransport,
+  DebugCallback,
+  EventEmitter,
+  RaceCancellation,
+  RootConnection,
+} from "../types";
 import _newProtocolConnection from "./newProtocolConnection";
 
 /**
@@ -24,6 +26,33 @@ export default function newProtocolConnection(
 
 export { default as newProtocolConnection } from "./newProtocolConnection";
 export type {
+  AttachJsonRpcTransport,
+  AttachMessageTransport,
+  AttachProtocolTransport,
+  AttachSession,
+  Cancellation,
+  DebugCallback,
+  DetachSession,
+  ErrorResponse,
+  Notification,
+  OnClose,
+  OnError,
+  OnEvent,
+  OnMessage,
+  OnNotification,
+  Protocol,
+  ProtocolMapping,
+  ProtocolError,
+  ProtocolTransport,
+  RaceCancellation,
+  Request,
+  Response,
+  ResponseError,
+  SendMessage,
+  SendMethod,
+  SendRequest,
+  SuccessResponse,
+  Task,
   ProtocolConnection,
   SessionConnection,
   RootConnection,

@tracerbench/protocol-connection/src/newEventHook.ts

@@ -1,6 +1,5 @@
-import Protocol from "devtools-protocol";
-
 import type {
+  Protocol,
   SessionConnection,
   SessionID,
   SessionIdentifier,

@tracerbench/protocol-connection/src/newProtocolConnection.ts

@@ -1,24 +1,23 @@
-import {
-  AttachProtocolTransport,
-  AttachSession,
-} from "@tracerbench/protocol-transport";
-import Protocol from "devtools-protocol";
 import {
   combineRaceCancellation,
   disposablePromise,
-  RaceCancellation,
   throwIfCancelled,
 } from "race-cancellation";
 
-import {
+import type {
+  AttachProtocolTransport,
+  AttachSession,
   NewEventEmitter,
+  Protocol,
   ProtocolConnection,
+  RaceCancellation,
   RootConnection,
   SessionConnection,
   SessionID,
   TargetID,
 } from "../types";
-import newEventHook, { Session } from "./newEventHook";
+import type { Session } from "./newEventHook";
+import newEventHook from "./newEventHook";
 
 /**
  * This method adapts a AttachProtocolTransport into higher level

@tracerbench/protocol-connection/types.d.ts

@@ -1,6 +1,62 @@
-import Protocol from "devtools-protocol";
-import { ProtocolMapping } from "devtools-protocol/types/protocol-mapping";
-import { RaceCancellation } from "race-cancellation";
+import type {
+  AttachJsonRpcTransport,
+  AttachMessageTransport,
+  AttachProtocolTransport,
+  AttachSession,
+  Cancellation,
+  DebugCallback,
+  DetachSession,
+  ErrorResponse,
+  Notification,
+  OnClose,
+  OnError,
+  OnEvent,
+  OnMessage,
+  OnNotification,
+  ProtocolError,
+  ProtocolTransport,
+  RaceCancellation,
+  Request,
+  Response,
+  ResponseError,
+  SendMessage,
+  SendMethod,
+  SendRequest,
+  SuccessResponse,
+  Task,
+} from "@tracerbench/protocol-transport";
+import type { Protocol } from "devtools-protocol";
+import type { ProtocolMapping } from "devtools-protocol/types/protocol-mapping";
+
+export type {
+  AttachJsonRpcTransport,
+  AttachMessageTransport,
+  AttachProtocolTransport,
+  AttachSession,
+  Cancellation,
+  DebugCallback,
+  DetachSession,
+  ErrorResponse,
+  Notification,
+  OnClose,
+  OnError,
+  OnEvent,
+  OnMessage,
+  OnNotification,
+  Protocol,
+  ProtocolMapping,
+  ProtocolError,
+  ProtocolTransport,
+  RaceCancellation,
+  Request,
+  Response,
+  ResponseError,
+  SendMessage,
+  SendMethod,
+  SendRequest,
+  SuccessResponse,
+  Task,
+};
 
 export type ProtocolConnection = SessionConnection | RootConnection;
 

@tracerbench/protocol-transport/src/index.ts

@@ -1,7 +1,9 @@
-import { AttachMessageTransport } from "@tracerbench/message-transport";
-import { RaceCancellation } from "race-cancellation";
-
-import { AttachProtocolTransport, DebugCallback } from "../types";
+import type {
+  AttachMessageTransport,
+  AttachProtocolTransport,
+  DebugCallback,
+  RaceCancellation,
+} from "../types";
 import newAttachJsonRpcTransport from "./newAttachJsonRpcTransport";
 import _newAttachProtocolTransport from "./newAttachProtocolTransport";
 
@@ -19,6 +21,13 @@ export { default as newAttachJsonRpcTransport } from "./newAttachJsonRpcTranspor
 export { default as newAttachProtocolTransport } from "./newAttachProtocolTransport";
 export { isProtocolError } from "./newProtocolError";
 export type {
+  AttachMessageTransport,
+  OnClose,
+  OnMessage,
+  SendMessage,
+  Cancellation,
+  RaceCancellation,
+  Task,
   AttachJsonRpcTransport,
   SendRequest,
   AttachProtocolTransport,
@@ -36,6 +45,5 @@ export type {
   ProtocolError,
   OnNotification,
   OnError,
-  OnClose,
   OnEvent,
 } from "../types";

@tracerbench/protocol-transport/src/newAttachJsonRpcTransport.ts

@@ -1,15 +1,15 @@
-import { AttachMessageTransport } from "@tracerbench/message-transport";
 import {
   cancellableRace,
   combineRaceCancellation,
-  RaceCancellation,
   throwIfCancelled,
 } from "race-cancellation";
 
-import {
+import type {
   AttachJsonRpcTransport,
+  AttachMessageTransport,
   DebugCallback,
   Notification,
+  RaceCancellation,
   Request,
   Response,
 } from "../types";

@tracerbench/protocol-transport/src/newAttachProtocolTransport.ts

@@ -1,9 +1,8 @@
-import { RaceCancellation } from "race-cancellation";
-
-import {
+import type {
   AttachJsonRpcTransport,
   AttachProtocolTransport,
   Notification,
+  RaceCancellation,
 } from "../types";
 import newProtocolError from "./newProtocolError";
 import newSessions from "./newSessions";

@tracerbench/protocol-transport/src/newProtocolError.ts

@@ -1,4 +1,4 @@
-import { ErrorResponse, ProtocolError, Request } from "../types";
+import type { ErrorResponse, ProtocolError, Request } from "../types";
 
 export default function newProtocolError(
   request: Request,

@tracerbench/protocol-transport/src/newResponses.ts

@@ -1,6 +1,7 @@
-import { Complete, oneshot } from "race-cancellation";
+import type { Complete } from "race-cancellation";
+import { oneshot } from "race-cancellation";
 
-import { Response } from "../types";
+import type { Response } from "../types";
 
 export default function newResponses(): [UsingResponse, ResolveResponse] {
   let seq = 0;

@tracerbench/protocol-transport/src/newSessions.ts

@@ -1,13 +1,10 @@
-import {
-  cancellableRace,
-  combineRaceCancellation,
-  RaceCancellation,
-} from "race-cancellation";
+import { cancellableRace, combineRaceCancellation } from "race-cancellation";
 
 import {
   AttachProtocolTransport,
   AttachSession,
   DetachSession,
+  RaceCancellation,
 } from "../types";
 
 export type DispatchEvent<SessionId> = (

@tracerbench/protocol-transport/types.d.ts

@@ -1,4 +1,20 @@
-import { RaceCancellation } from "race-cancellation";
+import {
+  AttachMessageTransport,
+  OnClose,
+  OnMessage,
+  SendMessage,
+} from "@tracerbench/message-transport";
+import { Cancellation, RaceCancellation, Task } from "race-cancellation";
+
+export type {
+  AttachMessageTransport,
+  OnClose,
+  OnMessage,
+  SendMessage,
+  Cancellation,
+  RaceCancellation,
+  Task,
+};
 
 export type AttachJsonRpcTransport = (
   onNotification: OnNotification,
@@ -92,7 +108,7 @@ export interface Notification<
   sessionId?: SessionID;
 }
 
-export type DebugCallback = (fmt: string, ...args: any[]) => void;
+export type DebugCallback = (formatter: unknown, ...args: unknown[]) => void;
 
 export interface ProtocolError<
   Method extends string = string,
@@ -110,7 +126,6 @@ export type OnNotification = <
   notification: Notification<Method, Params>,
 ) => void;
 export type OnError = (error: Error) => void;
-export type OnClose = () => void;
 export type OnEvent = <
   Event extends string = string,
   Params extends object = object

@tracerbench/spawn-chrome/src/canonicalizeOptions.ts

@@ -1,9 +1,9 @@
-import { SpawnOptions } from "../types";
+import type { ChromeSpawnOptions } from "../types";
 
 const CANONICALIZE: {
-  [K in keyof SpawnOptions]: Canonicalize<SpawnOptions[K]>;
+  [K in keyof ChromeSpawnOptions]: Canonicalize<ChromeSpawnOptions[K]>;
 } & {
-  [key: string]: Canonicalize<SpawnOptions[keyof SpawnOptions]>;
+  [key: string]: Canonicalize<ChromeSpawnOptions[keyof ChromeSpawnOptions]>;
 } = {
   additionalArguments: arrayOf("string"),
   chromeExecutable: primitive("string"),
@@ -13,6 +13,9 @@ const CANONICALIZE: {
   url: primitive("string"),
   userDataDir: primitive("string"),
   userDataRoot: primitive("string"),
+  cwd: primitive("string"),
+  extendEnv: primitive("boolean"),
+  env: env(),
 };
 
 type Canonicalize<T> = (value: unknown, key: string) => T;
@@ -62,9 +65,20 @@ function arrayOf<T extends keyof PrimitiveMapping>(
   };
 }
 
-export default function canonicalizeOptions(options: unknown): SpawnOptions {
-  const canonical: SpawnOptions & {
-    [key: string]: SpawnOptions[keyof SpawnOptions];
+function env(): Canonicalize<{ [name: string]: string | undefined }> {
+  return (value, key) => {
+    if (isObject(value)) {
+      return value as { [name: string]: string | undefined };
+    }
+    return invalidOption(key, "env");
+  };
+}
+
+export default function canonicalizeOptions(
+  options: unknown,
+): ChromeSpawnOptions {
+  const canonical: ChromeSpawnOptions & {
+    [key: string]: ChromeSpawnOptions[keyof ChromeSpawnOptions];
   } = {
     additionalArguments: undefined,
     chromeExecutable: undefined,
@@ -74,6 +88,9 @@ export default function canonicalizeOptions(options: unknown): SpawnOptions {
     url: undefined,
     userDataDir: undefined,
     userDataRoot: undefined,
+    cwd: undefined,
+    extendEnv: undefined,
+    env: undefined,
   };
 
   if (isObject(options)) {

@tracerbench/spawn-chrome/src/getArguments.ts

@@ -1,4 +1,4 @@
-import { ArgumentOptions } from "../types";
+import type { ArgumentOptions } from "../types";
 import defaultFlags, { headlessFlags } from "./defaultFlags";
 
 export default function getArguments(

@tracerbench/spawn-chrome/src/index.ts

@@ -1,4 +1,23 @@
-export type { ArgumentOptions, SpawnOptions, Chrome } from "../types";
+export type {
+  AttachMessageTransport,
+  Cancellation,
+  DebugCallback,
+  OnClose,
+  OnMessage,
+  Process,
+  ProcessWithPipeMessageTransport,
+  ProcessWithWebSocketUrl,
+  RaceCancellation,
+  SendMessage,
+  SpawnOptions,
+  Stdio,
+  Task,
+  Transport,
+  TransportMapping,
+  ArgumentOptions,
+  ChromeSpawnOptions,
+  Chrome,
+} from "../types";
 export { default } from "./spawnChrome";
 export { defaultFlags, headlessFlags } from "./defaultFlags";
 export { default as getArguments } from "./getArguments";