Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when importing missing backing files for existing books #1159

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix crash when importing missing backing files for existing books #1159

merged 2 commits into from
Aug 1, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • The app is crashing when trying to add back files that were removed for existing books in the library

Approach

  • Add the same logic to request access to iCloud docs before attempting to move or copy the file

Things to be aware of / Things to focus on

  • This also includes an update to fix the UI being updated on a background thread in the Storage management screen

@GianniCarlo GianniCarlo self-assigned this Jul 31, 2024
@GianniCarlo GianniCarlo merged commit 2e077f9 into develop Aug 1, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the crash-import-existing branch August 1, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo