Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle PDK_ROOT being unset for the docker command line #66

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

htfab
Copy link
Collaborator

@htfab htfab commented Sep 20, 2024

Resolves #65

@urish
Copy link
Member

urish commented Sep 21, 2024

Thanks! Note that if PDK_ROOT is unset, this will fail later, at the end of the flow, too:

os.environ["PDK_ROOT"],

@urish urish merged commit dd77f85 into TinyTapeout:tt09 Sep 23, 2024
3 checks passed
@urish
Copy link
Member

urish commented Sep 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When PDK_ROOT is not set, we're getting a default value of "--docker-no-tty"
2 participants