Add configuration parameter to load enumerations on all schemas. #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatia
approved these changes
Nov 20, 2024
| @@ -904,32 +892,24 @@ Array::get_enumerations_all_schemas() { | |||
| } | |||
|
|
|||
| // Store the loaded enumerations into the schemas. | |||
| auto latest_schema = opened_array_->array_schema_latest_ptr(); | |||
| for (const auto& schema_enmrs : ret) { | |||
| for (const auto& [schema_name, enmrs] : ret) { | |||
|
I am merging this so that we can proceed with the release but Academy docs will need to be updated eventually with that config change. cc @shaunrd0 @nickvigilante |
ihnorton
added a commit
that referenced
this pull request
Nov 20, 2024
This adds a new config parameter `rest.load_enumerations_on_array_open_all_schemas` to control loading enumerations on all array schemas. The previously existing `rest.load_enumerations_on_array_open` config parameter is used to control loading enumerations on the latest schema only. --- TYPE: FEATURE DESC: Add `rest.load_enumerations_on_array_open_all_schemas` config parameter. --------- Co-authored-by: Isaiah Norton <[email protected]>
nickvigilante
added a commit
that referenced
this pull request
Nov 20, 2024
Updated config_api_external.h to match config.h
shaunrd0
added a commit
that referenced
this pull request
Nov 20, 2024
Update docs for REST enumeration config options. --- TYPE: NO_HISTORY --------- Co-authored-by: Shaun Reed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new config parameter
rest.load_enumerations_on_array_open_all_schemasto control loading enumerations on all array schemas. The previously existingrest.load_enumerations_on_array_openconfig parameter is used to control loading enumerations on the latest schema only.TYPE: FEATURE
DESC: Add
rest.load_enumerations_on_array_open_all_schemasconfig parameter.