Add tiledb_field_get_nullable API #5378
Conversation
| int64_t d2[] = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1}; | ||
| uint64_t d1_size = 10 * sizeof(int64_t); | ||
| uint64_t d2_size = 10 * sizeof(int64_t); | ||
| int32_t a[] = {1, 2, 3, 4, 5, 6, 7, 8, 9}; |
There was a problem hiding this comment.
The last cell doesn't make it through the write (one of the other inputs only has nine cells) so I elected to remove it to avoid future confusion.
(e.g. a developer expecting a sum of 55 rather than 45, you can probably guess who did that)
| TILEDB_EXPORT capi_return_t tiledb_field_get_nullable( | ||
| tiledb_ctx_t* ctx, | ||
| tiledb_query_field_t* field, | ||
| uint8_t* nullable) TILEDB_NOEXCEPT; |
There was a problem hiding this comment.
I would call it is_nullable.
There was a problem hiding this comment.
I considered that, in the end I chose to mimic tiledb_attribute_get_nullable
There is no analog in the C++ API for query field. They were introduced in #4385 which did not add anything in C++ and to date nothing has been added. I don't think this PR is the place to do so. |
tiledb/api/c_api/query_field/query_field_api_external_experimental.h
Outdated
Show resolved
Hide resolved
|
Oh I didn't know query field has a C++ API, opened SC-59555 to track it.
OK, I saw some other APIs also not having |
rroelke
force-pushed
the
rr/sc-59534-tiledb_field_get_nullable
branch
from
e71f424
to
a128278
Compare
…ntal.h Co-authored-by: Beka Davis <[email protected]>
The set of "query field" APIs offers a means to ask about the datatype and cell val num of a query result field without understanding whether the queried field is a dimension, attribute, or aggregate.
For aggregates in particular
tiledb_field_datatypeandtiledb_field_cell_val_numallow a user to ask about the result type of their aggregate function operation, without having to read docs, source code, etc.To date, however, there has not been a way to ask if a query field can be null. This pull request adds that, via a C API
tiledb_field_get_nullable.TYPE: C_API
DESC: Add
tiledb_field_get_nullableAPI