Add Config::login API. #5377
Open
Add Config::login API. #5377
+107
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekadavis9
force-pushed
the
rd/config_unification
branch
from
df2026c
to
3a2abf9
Compare
bekadavis9
force-pushed
the
rd/config_unification
branch
from
b87a31c
to
6406980
Compare
Comment on lines
+576
to
+578
| // For library versions 2.27.0 and older, simply parse the local .json file | ||
| auto version = constants::library_version; | ||
| if (version[0] <= 2 && version[1] <= 27) { |
There was a problem hiding this comment.
I don't understand this, dev will soon switch to 2.28 and and this will always be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Config::loginAPI, which logs into TileDB Cloud, saving the profile to the internal configuration.TYPE: FEATURE
DESC: Add
Config::loginAPI.