Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove serialization non C.41 constructors from Subarray. #4685

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Remove serialization non C.41 constructors from Subarray. #4685

wants to merge 10 commits into from
+339 −212

Commits on Mar 4, 2024

  1. Add C.41 Subarray constructor 

    + Unstatus subarray_from_capnp
    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7464c41 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    fc6c31f View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1f98d52 View commit details
    Browse the repository at this point in the history

  4. Remove set_subarray_unsafe

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3ac3cf3 View commit details
    Browse the repository at this point in the history

  5. Clean code

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    cff8cdc View commit details
    Browse the repository at this point in the history

  6. Update Stats deserialization

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6c79915 View commit details
    Browse the repository at this point in the history

  7. Feedback from review

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b6009a6 View commit details
    Browse the repository at this point in the history

  8. Use reserve for label_range_subset

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b86a687 View commit details
    Browse the repository at this point in the history

  9. Make Subarray::add_range_unsafe private

    @shaunrd0
    shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    712fa4b View commit details
    Browse the repository at this point in the history

  10. Making methods public again.

    @KiterLuc @shaunrd0
    KiterLuc authored and shaunrd0 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c9e4726 View commit details
    Browse the repository at this point in the history