update default response

Thumimku · Nov 2, 2023 · 898c1ab · 898c1ab
1 parent 937246f
commit 898c1ab
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/...rg/wso2/carbon/identity/client/attestation/mgt/services/ClientAttestationServiceImpl.java b/...rg/wso2/carbon/identity/client/attestation/mgt/services/ClientAttestationServiceImpl.java
@@ -127,11 +127,24 @@ public ClientAttestationContext validateAttestation(String attestationObject,
                 ClientAttestationValidator androidAttestationValidator = new AndroidAttestationValidator(clientId,
                         tenantDomain, serviceProvider.getClientAttestationMetaData());
                 androidAttestationValidator.validateAttestation(attestationObject, clientAttestationContext);
+                return clientAttestationContext;
+            } else {
+                handleInvalidAttestationObject(clientAttestationContext);
+                return clientAttestationContext;
             }
         } catch (ClientAttestationMgtException e) {
             handleClientAttestationException(e, clientAttestationContext);
+            return clientAttestationContext;
+        }
+    }
+
+    private void handleInvalidAttestationObject(ClientAttestationContext clientAttestationContext) {
+
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Requested attestation object is not in valid format.");
         }
-        return clientAttestationContext;
+        setErrorToContext("Requested attestation object is not in valid format.",
+                clientAttestationContext);
     }
 
     private void handleClientAttestationException

diff --git a/...y.core.server.feature/resources/org.wso2.carbon.identity.core.server.feature.default.json b/...y.core.server.feature/resources/org.wso2.carbon.identity.core.server.feature.default.json
@@ -1260,7 +1260,6 @@
   "organization_management.self_service.default_system_app_name": "B2B-Self-Service-Mgt-Application",
   "organization_management.self_service.default_token_expiry_time": "7200",
   "organization_management.self_service.internal_role_name": "B2B-SS-System-Role",
-  "organization_management.self_service.user_store_name_for_system_user": "PRIMARY"
-  "input_validation.default_validator": "alphaNumeric",
+  "organization_management.self_service.user_store_name_for_system_user": "PRIMARY",
   "client_attestation.allowed_window": "60000"
 }
diff --git a/pom.xml b/pom.xml
@@ -669,6 +669,11 @@
                 <artifactId>org.wso2.carbon.identity.api.resource.mgt.server.feature</artifactId>
                 <version>${project.version}</version>
             </dependency>
+            <dependency>
+                <groupId>com.google.api-client</groupId>
+                <artifactId>google-api-client</artifactId>
+                <version>${com.google.client.version}</version>
+            </dependency>
             <dependency>
                 <groupId>com.google.apis</groupId>
                 <artifactId>google-api-services-admin</artifactId>