-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored logic.py method filter_cites #8
Conversation
… is need to continue if-elif statement check nor append value to a list
…e is need to continue if-elif statement check nor append value to a list
refactored logic.py method filter_cites (see commit "changes") |
After more careful inspection I'm not sure anymore if the intention was to return a list of objects or a singular object since I was only reading the code first, not the commented return args. If the intention was to return a list of objects, then a new test should be probably implemented to test this as the current tests are passing with the existing code & my changes. |
List[Cite] -> list[Cite]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 92.57% 96.70% +4.13%
==========================================
Files 7 8 +1
Lines 175 182 +7
Branches 20 17 -3
==========================================
+ Hits 162 176 +14
+ Misses 10 5 -5
+ Partials 3 1 -2 ☔ View full report in Codecov by Sentry. |
ohtu viikko6:
Tyhjän pull requestin tarkoituksena on varata sinulle paikka kyseisen repositorion muutoksentekijöiden joukosta