Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored logic.py method filter_cites #8

Merged
merged 8 commits into from
Dec 10, 2023
Merged

refactored logic.py method filter_cites #8

merged 8 commits into from
Dec 10, 2023

Conversation

koenol
Copy link
Contributor

@koenol koenol commented Dec 9, 2023

ohtu viikko6:
Tyhjän pull requestin tarkoituksena on varata sinulle paikka kyseisen repositorion muutoksentekijöiden joukosta

… is need to continue if-elif statement check nor append value to a list
…e is need to continue if-elif statement check nor append value to a list
@koenol koenol changed the title empty line README.md refractored logic.py method filter_cites Dec 9, 2023
@koenol koenol changed the title refractored logic.py method filter_cites refactored logic.py method filter_cites Dec 9, 2023
@koenol
Copy link
Contributor Author

koenol commented Dec 9, 2023

refactored logic.py method filter_cites (see commit "changes")
since only the initial result/element is returned I don't think there is a need to continue the if--statement check nor append value to a list.

@koenol
Copy link
Contributor Author

koenol commented Dec 9, 2023

After more careful inspection I'm not sure anymore if the intention was to return a list of objects or a singular object since I was only reading the code first, not the commented return args. If the intention was to return a list of objects, then a new test should be probably implemented to test this as the current tests are passing with the existing code & my changes.

List[Cite] -> list[Cite]
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc59350) 92.57% compared to head (ba5eeb8) 96.70%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   92.57%   96.70%   +4.13%     
==========================================
  Files           7        8       +1     
  Lines         175      182       +7     
  Branches       20       17       -3     
==========================================
+ Hits          162      176      +14     
+ Misses         10        5       -5     
+ Partials        3        1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJiahao TheJiahao merged commit dce5593 into TheJiahao:main Dec 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants