Skip to content

Commit

Permalink
Update to laravel 10 and add laravel-analytics
Browse files Browse the repository at this point in the history
  • Loading branch information
Claudio-Emmolo committed Aug 7, 2023
1 parent a0a5e79 commit 5c8321a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
14 changes: 4 additions & 10 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,12 @@
],
"require": {
"php": "^8.1|^8.2",
"outl1ne/nova-translations-loader": "^5.0"
"spatie/laravel-analytics": "^5.0.3",
"laravel/framework": "^10.0"
},
"require-dev": {
"laravel/nova": "^4.0",
"laravel/pint": "^1.10",
"nunomaduro/larastan": "2.0",
"orchestra/testbench": "^7.0",
"phpunit/phpunit": "^9.5"
"laravel/pint": "^1.10"
},
"autoload": {
"psr-4": {
Expand All @@ -60,14 +58,10 @@
"config": {
"sort-packages": true,
"allow-plugins": {
"php-http/discovery": true,
"pestphp/pest-plugin": true
"php-http/discovery": true
}
},
"scripts": {
"post-autoload-dump": [
"@php vendor/bin/testbench package:discover --ansi"
],
"lint": [
"./vendor/bin/pint"
],
Expand Down
3 changes: 1 addition & 2 deletions src/Abstract/GoogleAnalyticsCounter.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@

abstract class GoogleAnalyticsCounter extends Value
{
public function __construct(string $name = null, string $metrics = null)
public function __construct(string $name = null)
{
parent::__construct();
$this->name = $name ?? __($this->title);
$this->metrics = $metrics;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/NovaGoogleAnalyticsCardsServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function boot()
__DIR__.'/../config/nova-google-analytics-cards.php' => config_path('nova-google-analytics-cards.php'),
], 'config');

$this->loadTranslations(__DIR__.'/../lang', 'nova-google-analytics-cards', true);
// $this->loadTranslations(__DIR__.'/../lang', 'nova-google-analytics-cards', true);
}

/**
Expand Down
Empty file removed tests/.gitkeep
Empty file.

0 comments on commit 5c8321a

Please sign in to comment.