Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAP-78] - feat: add SDK start block logic when extension is active #27

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LucasScheffelTB
Copy link

@LucasScheffelTB LucasScheffelTB commented Oct 8, 2024

What did I change:

  • Implemented logic to block the SDK start when the Extension is active.
  • Improved logging methods for TBX SDK.

QA Notes:

QA Notes on Linear Task: https://linear.app/testbox/issue/CAP-78/[browser-sdk]-disable-load-when-extension-is-present

Related Tickets:

https://linear.app/testbox/issue/CAP-78/[browser-sdk]-disable-load-when-extension-is-present

Did you...

  • test the code locally?
  • run unit tests and updated to account for the changes?
  • lint the code?
  • format the code?
  • test the code on staging?

src/index.ts Show resolved Hide resolved
cypress/cdn.test.ts Outdated Show resolved Hide resolved
cypress/cdn.test.ts Outdated Show resolved Hide resolved
augustolgunsch
augustolgunsch previously approved these changes Oct 29, 2024
Copy link

@augustolgunsch augustolgunsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't entirely get the context of this change, but from the ticket's description, it seems correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants