Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to interactjs 1.10.27 #7318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 19, 2024

What this PR does

I don't have Safari, but TerriaMap
supposedly does "not work with
Safari".

The interactjs version that
is used has multiple bugs that
affect Safari, for example:

taye/interact.js#682

so bump the version to the latest
interactjs in hope that it makes
things better for Safari.

Test me

I believe this is tested by CI?

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson pjonsson force-pushed the update-interactjs branch 2 times, most recently from c6d3ba6 to 5fc5c22 Compare November 29, 2024 00:27
I don't have Safari, but TerriaMap
supposedly does "not work with
Safari".

The interactjs version that
is used has multiple bugs that
affect Safari, for example:

taye/interact.js#682

so bump the version to the latest
interactjs in hope that it makes
things better for Safari.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant