Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/image viewer #282

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Kryst4ljy
Copy link

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#259

💡 需求背景和解决方案

📝 更新日志

  • fix(imageViewer): 新增组件 imageViewer

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@LeeJim
Copy link
Collaborator

LeeJim commented Aug 12, 2022

抱歉啊。最近有点忙,一直没合并

@github-actions
Copy link
Contributor

失败

Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要调整两个地方,

  • 多图切换应该底层依赖 swiper 来实现
  • 样式有点问题,不知道是不是因为 MobileVue 最近重构了一下

@Kryst4ljy
Copy link
Author

多图切换我后续调整下。

@Kryst4ljy
Copy link
Author

需要调整两个地方,

  • 多图切换应该底层依赖 swiper 来实现
  • 样式有点问题,不知道是不是因为 MobileVue 最近重构了一下

样式问题应该是我的样式没更新,在 tdesign-common 那边提交了个 pr。Tencent/tdesign-common#692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants