Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 10 scoped storage fix #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scr34m
Copy link

@scr34m scr34m commented Sep 10, 2020

This change uses MediaStore interface to query camera images.
Tested in emulator on an Android 10 device, works correctly.

@scr34m
Copy link
Author

scr34m commented Sep 16, 2020

Bounds check was used with ImageDecoder now changed to use meta data from MediaStore to avoid reading in the image, much faster now.

Added a missing function to set sample size with ImageDecoder.

@saviour2008
Copy link

could you tell me if I install version 2.3.3 in ionic build, does the 2.3.3 version include the Android 10 fixed?@scr34m

@scr34m
Copy link
Author

scr34m commented Oct 15, 2020

I'm currently using rev. master@ecf2c79366ac9a69c89a47c5799cde4205d7d9c9 so i can't tell you more.
But the changes in manifest xml not solve the issue, my fix does.

@uaza
Copy link

uaza commented Mar 5, 2022

The error that no pictures can be selected actually only occurs with Android 10. Android 9 and smaller or Android 11 and larger already worked without this fix.

I have retested this fix on an Android 10 (Huawei P30 lite). Would be great if this pull request could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants