Allow timecode to be used as timestamp in Share Modal #1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the share modal only allows timestamp to be in seconds. This PR allows the timestamp to be in seconds as well as in
HH:MM:SS
format.Some points to note:
Intl.DateFormat
.HH:MM:SS
format, the seconds/minutes/hours value can be more than expected, which is handled without errors. For example:10:61
will return&t=661
. This can be changed if intended, but imo it's quite convenient.actions.time_code
translations to reflect the new changes.