-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#67] 소식 탭 뉴스 뷰 구현 #72
Open
JinUng41
wants to merge
7
commits into
develop
Choose a base branch
from
feat/#67
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 배너 이미지 추가 - 루트 뷰 구현
- 서버에서 내려주는 고유한 id 값만을 비교군으로 삼도록 수정
- 모든 내용이 스크롤 될 수 있도록 함.
- 배지를 제외한 뉴스 조회 / 페이지네이션 / 새로고침 / 상세보기 구현
binisnil
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드를 볼 수록 느끼는거지만 언어 활용 능력치가 굉장하신 것 같아요!
많이 보고 배우겠습니다 🙇🏻♀️🙇🏻♀️
고생 많으셨어요!!
input.collectionViewDidEndDrag | ||
.compactMap { newsSubject.value.last?.id } | ||
.filter { [weak self] lastNewsID in | ||
newsSubject.value.count % 15 == 0 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
페이징 로직..! 깔끔하고 더 보기 좋네요,, 페이징로직 수정할 때 참고해서 진행하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻 PULL REQUEST
🛠️ PR POINT
📍 시간 형식 변경을 위한 Formatter 객체
extension
으로 형식을 바꾸는 메서드를 정의할 경우,dateFormatter
가 배열을 순회하면서 생성되고 쓰이고 사라지고를 반복하는데요.NewsTimeFormatter 코드
💡 참고사항
📸 스크린샷
📟 관련 이슈