Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166 [ui] 카드 기기대응 DimensionRatio 적용 #167

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

pump9918
Copy link
Collaborator

@pump9918 pump9918 commented Mar 8, 2024

📑 Work Description

  • 뷰페이저에만 적용되어 있던 DimensionRatio 전체 행복루틴 카드에 적용

🛠️ Issue

📷 Screenshot

Screen_recording_20240308_112612.mp4

💬 To Reviewers

뷰페이저의 카드 크기와 다른 카드들의 사이즈를 통일했습니다

@pump9918 pump9918 self-assigned this Mar 8, 2024
@pump9918 pump9918 added UI ui 관련 작업 호연🐻‍❄️ 호연이가 작업함! labels Mar 8, 2024
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 좋아요~ 왜 이렇게 카드가 사람 속을 썩이는지

Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아직 고정디피였군요 카드가 끝까지 귀찮게 하네유 수고하셨슴다!!

Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카드 제발 그만 속썩여줘.. 진짜 수고하셨습니당!!

@pump9918 pump9918 merged commit 36f73bd into develop Mar 9, 2024
1 check passed
@stellar-halo stellar-halo deleted the feature/#166-refactoring-card-size branch March 13, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI ui 관련 작업 호연🐻‍❄️ 호연이가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ui] 카드 기기대응 DimensionRatio 적용
4 participants