Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] GoalService 테스트 코드 작성 #297

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[TEST] GoalService 테스트 코드 작성 #297

merged 2 commits into from
Jun 11, 2024

Conversation

unanchoi
Copy link
Contributor

Related issue 🚀

Work Description 💚

  • 성공 케이스에 대해서 GoalService test code를 작성했습니다.

@unanchoi unanchoi requested a review from thguss May 28, 2024 11:01
@unanchoi unanchoi self-assigned this May 28, 2024
@unanchoi unanchoi added UNAN🐻 Unan 작업 TEST labels May 28, 2024
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Comment on lines 66 to 70
Goal.builder()
.type(GoalType.DEVELOP)
.way("Test Way")
.detail("Test Detail")
.build()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoalFixture를 사용하지 않은 이유가 있나요!?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큰 이유는 없습니다 ~ ㅋㅋ

Comment on lines 73 to 74
val request = GoalGetServiceRequest.of(GoalType.DEVELOP);
// when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 줄 띄어쓰기 부탁드립니당~

@unanchoi unanchoi merged commit 158ad5c into develop Jun 11, 2024
1 check passed
@unanchoi unanchoi deleted the unan#285 branch June 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST UNAN🐻 Unan 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoalService test code 작성
2 participants