[FEAT/#220] 2차 스프린트 뷰 / 프로필, 확장함수, CustomEtv 전체 삭제 기능 구현 #222
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package com.going.presentation.profile.edit | ||
|
|
||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.os.Bundle | ||
| import androidx.activity.viewModels | ||
| import androidx.core.widget.doAfterTextChanged | ||
| import androidx.lifecycle.flowWithLifecycle | ||
| import androidx.lifecycle.lifecycleScope | ||
| import com.going.presentation.R | ||
| import com.going.presentation.databinding.ActivityProfileEditBinding | ||
| import com.going.ui.base.BaseActivity | ||
| import com.going.ui.extension.setOnSingleClickListener | ||
| import dagger.hilt.android.AndroidEntryPoint | ||
| import kotlinx.coroutines.flow.launchIn | ||
| import kotlinx.coroutines.flow.onEach | ||
|
|
||
| @AndroidEntryPoint | ||
| class ProfileEditActivity : | ||
| BaseActivity<ActivityProfileEditBinding>(R.layout.activity_profile_edit) { | ||
| private val viewModel by viewModels<ProfileEditViewModel>() | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| setEtNameArguments() | ||
| setEtInfoArguments() | ||
| getUserInfo() | ||
| observeNameTextChanged() | ||
| observeInfoTextChanged() | ||
| observeIsValueChanged() | ||
| initBackBtnClickListener() | ||
| } | ||
|
|
||
| private fun setEtNameArguments() { | ||
| with(binding.etProfileEditNickname) { | ||
|
Comment on lines
+35
to
+36
There was a problem hiding this comment. 근데 진심 이거 쩌는 것 같아요...... 확 간결해지는 마법 |
||
| setMaxLen(viewModel.getMaxNameLen()) | ||
| overWarning = getString(R.string.name_over_error) | ||
| blankWarning = getString(R.string.name_blank_error) | ||
| } | ||
| } | ||
|
|
||
| private fun setEtInfoArguments() { | ||
| with(binding.etProfileEditInfo) { | ||
| setMaxLen(viewModel.getMaxInfoLen()) | ||
| overWarning = getString(R.string.info_over_error) | ||
| } | ||
| } | ||
|
|
||
| private fun observeNameTextChanged() { | ||
| binding.etProfileEditNickname.editText.doAfterTextChanged { name -> | ||
| viewModel.checkIsNameChanged(name.toString()) | ||
| } | ||
| } | ||
|
|
||
| private fun observeInfoTextChanged() { | ||
| binding.etProfileEditInfo.editText.doAfterTextChanged { info -> | ||
| viewModel.checkIsInfoChanged(info.toString()) | ||
| } | ||
| } | ||
|
Comment on lines
+50
to
+60
There was a problem hiding this comment. 오,,, |
||
|
|
||
| private fun getUserInfo() { | ||
| val name = intent.getStringExtra(NICKNAME) | ||
| val info = intent.getStringExtra(INFO) | ||
|
|
||
| with(binding) { | ||
| etProfileEditNickname.editText.setText(name) | ||
| etProfileEditInfo.editText.setText(info) | ||
| } | ||
| viewModel.setDefaultValues(name.orEmpty(), info.orEmpty()) | ||
| } | ||
|
|
||
| private fun observeIsValueChanged() { | ||
| viewModel.isValueChanged.flowWithLifecycle(lifecycle).onEach { state -> | ||
| binding.btnProfileEditFinish.isEnabled = state | ||
| }.launchIn(lifecycleScope) | ||
| } | ||
|
|
||
| private fun initBackBtnClickListener() { | ||
| binding.btnProfileEditBack.setOnSingleClickListener { | ||
| finish() | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| const val NICKNAME = "NICKNAME" | ||
| const val INFO = "INFO" | ||
|
There was a problem hiding this comment. createIntent를 활용하면 키값을 private으로 돌려도 작동함당 ! There was a problem hiding this comment. private 했습니다... 그것이..캡슐화니까... |
||
|
|
||
| @JvmStatic | ||
| fun createIntent( | ||
| context: Context, | ||
| nickName: String, | ||
| info: String, | ||
| ): Intent = Intent(context, ProfileEditActivity::class.java).apply { | ||
| putExtra(NICKNAME, nickName) | ||
| putExtra(INFO, info) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| package com.going.presentation.profile.edit | ||
|
|
||
| import androidx.lifecycle.ViewModel | ||
| import com.going.presentation.onboarding.signup.SignUpViewModel | ||
| import kotlinx.coroutines.flow.MutableStateFlow | ||
| import kotlinx.coroutines.flow.StateFlow | ||
|
|
||
| class ProfileEditViewModel : ViewModel() { | ||
| private val _isValueChanged = MutableStateFlow(false) | ||
| val isValueChanged: StateFlow<Boolean> = _isValueChanged | ||
|
|
||
| private var isNameChanged = false | ||
| private var isInfoChanged = false | ||
|
|
||
| private lateinit var nowName: String | ||
| private lateinit var nowInfo: String | ||
| private lateinit var defaultName: String | ||
| private lateinit var defaultInfo: String | ||
|
|
||
| fun setDefaultValues(name: String, info: String) { | ||
| nowName = name | ||
| nowInfo = info | ||
|
|
||
| defaultName = name | ||
| defaultInfo = info | ||
| } | ||
|
Comment on lines
+20
to
+26
There was a problem hiding this comment. 아하 요렇게 디폴트 값으로 이름이랑 정보 넣어두고 검사하는 로직이군여!! |
||
|
|
||
| fun checkIsNameChanged(name: String) { | ||
| nowName = name | ||
| isNameChanged = name != defaultName | ||
|
|
||
| checkIsValueChanged() | ||
| } | ||
|
|
||
| fun checkIsInfoChanged(info: String) { | ||
| nowInfo = info | ||
| isInfoChanged = info != defaultInfo | ||
|
|
||
| checkIsValueChanged() | ||
| } | ||
|
|
||
| private fun checkIsValueChanged() { | ||
| _isValueChanged.value = | ||
| nowName.length <= getMaxNameLen() && nowInfo.length <= getMaxInfoLen() && (isInfoChanged || isNameChanged) | ||
| } | ||
|
|
||
| fun getMaxNameLen() = SignUpViewModel.MAX_NAME_LEN | ||
|
|
||
| fun getMaxInfoLen() = SignUpViewModel.MAX_INFO_LEN | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와 보니깐 아워투두 친구목록에도 테두리 있었네 머지하면 쓰겟삼 최고~~