Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of resizeItem #637

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Update documentation of resizeItem #637

merged 1 commit into from
Dec 22, 2023

Conversation

autarc
Copy link
Contributor

@autarc autarc commented Dec 18, 2023

Pull Request

There is currently a mismatch of the documentation and the definition/handling in the code regarding the resizeItem method which is utilized to adjust the size of an item.

Screenshot 2023-12-18 at 13 44 38

After a prior update (3270b6c) the first argument got changed from being an item index (= number) to a reference of an virtualItem itself. With the alignment in the docs it consistency in usage will be ensured.

Screenshot 2023-12-18 at 13 48 45

@piecyk
Copy link
Collaborator

piecyk commented Dec 22, 2023

Thanks @autarc

@piecyk piecyk merged commit 26dca7c into TanStack:main Dec 22, 2023
1 of 2 checks passed
@autarc autarc deleted the docs-update-item-reference branch January 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants