Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(translations), Documentation, Typing and an assortment of fixes #1305

Merged
merged 31 commits into from
Nov 22, 2024

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented Nov 22, 2024

  • Add compile_translations module to CI

  • Fixes broken translation from Ricardo simoes patch 2 #1224

  • Added necessary definitions to phazor.c to pass MSVC compiler and move unistd.h under non-Windows block

    • I did not get Tauon to compile on MSVC as a whole in the end, but I am not hard stuck yet
  • Added a bunch of Windows MSVC notes in pyproject.toml - untidy, for now

  • Fix trying to use a hardcoded /usr/share/TauonMusicBox path even when it does not exist on the system

  • run.sh fix for running from a downloaded zip file

  • Renamed .env to the more standard .venv

  • More spaces to tabs in main

  • Fixed crashing on exit

  • Removed unused temp_audio var

  • Removed unused arg from no_padding()

  • Converted more code to Path where applicable, converts to str() where necessary

  • Changed system to use capitalized names, to match platform.system()

  • Typing additions and fixes

@C0rn3j C0rn3j changed the title Documentation, typing, assortment of fixes CI(translations), Documentation, Typing and an assortment of fixes Nov 22, 2024
@C0rn3j C0rn3j mentioned this pull request Nov 22, 2024
@Ricardo-Simoes
Copy link
Contributor

How did my translations broke the translations???? I don't understand, please clarify.

@C0rn3j
Copy link
Collaborator Author

C0rn3j commented Nov 22, 2024

How did my translations broke the translations???? I don't understand, please clarify.

I've posted the log in #1224 (comment), you can get it yourself by running python compile_translations.py.

There are now a couple duplicates.

It does look like the translations lack updates though, as Broadcast This does not even seem to be anywhere in the current code, I'll look into that.

locale/pt/LC_MESSAGES/tauon.po:3095: duplicate message definition...
locale/pt/LC_MESSAGES/tauon.po:1520: ...this is the location of the first definition
locale/pt/LC_MESSAGES/tauon.po:3098: duplicate message definition...
locale/pt/LC_MESSAGES/tauon.po:1524: ...this is the location of the first definition
locale/pt/LC_MESSAGES/tauon.po:3101: duplicate message definition...
locale/pt/LC_MESSAGES/tauon.po:1532: ...this is the location of the first definition
locale/pt/LC_MESSAGES/tauon.po:3226: duplicate message definition...
locale/pt/LC_MESSAGES/tauon.po:2232: ...this is the location of the first definition
msgmerge: found 4 fatal errors
Updated: pt
. done.
Updated: pl
. done.
Updated: es
locale/pt_PT/LC_MESSAGES/tauon.po:3265: duplicate message definition...
locale/pt_PT/LC_MESSAGES/tauon.po:1383: ...this is the location of the first definition
msgmerge: found 1 fatal error

This is from the update translation script btw... I suppose all of this is simple duplicates?

I'll check if any of the deletes are not obvious.

@C0rn3j
Copy link
Collaborator Author

C0rn3j commented Nov 22, 2024

@Ricardo-Simoes There was only one that wasn't an obvious duplicate, I presume I deleted the correct one?

# KEPT: 
msgid "There are no tracks in this playlist to broadcast."
msgstr "Não há faixas nesta lista de reprodução para transmitir."

# REMOVED:
#~ msgid "There are no tracks in this playlist to broadcast."
#~ msgstr "Não há faixas nesta playlist para transmitir."

@Taiko2k Taiko2k merged commit 9b5836e into Taiko2k:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants