feat: adding clickble symbol render in chat panel #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
Nov 17, 2024
| @@ -94,6 +105,7 @@ export function createClient(target: HTMLIFrameElement, api: ClientApi): ServerA | |||
| onLoaded: api.onLoaded, | |||
| onCopy: api.onCopy, | |||
| onKeyboardEvent: api.onKeyboardEvent, | |||
| onRenderLsp: api.onRenderLsp, | |||
There was a problem hiding this comment.
Suggested change
| onRenderLsp: api.onRenderLsp, | |
| onNavigateSymbol: api.onNavigateSymbol, |
wsxiaoys
reviewed
Nov 17, 2024
| @@ -53,7 +53,14 @@ export interface ServerApi { | |||
| updateTheme: (style: string, themeClass: string) => void | |||
| updateActiveSelection: (context: Context | null) => void | |||
| } | |||
|
|
|||
| export interface KeywordInfo { | |||
There was a problem hiding this comment.
Suggested change
| export interface KeywordInfo { | |
| export interface SymbolInfo { |
wsxiaoys
reviewed
Nov 17, 2024
| export interface KeywordInfo { | ||
| sourceFile: string | ||
| sourceLine: number | ||
| sourceChar: number |
There was a problem hiding this comment.
Suggested change
| sourceChar: number | |
| sourceCol: number |
wsxiaoys
changed the title
wsxiaoys
reviewed
Nov 18, 2024
| @@ -69,6 +76,10 @@ export interface ClientApi { | |||
| onCopy: (content: string) => void | |||
|
|
|||
| onKeyboardEvent: (type: 'keydown' | 'keyup' | 'keypress', event: KeyboardEventInit) => void | |||
| onRenderLsp: (filepaths: string[], keywords: string[]) => Promise<Record< | |||
There was a problem hiding this comment.
Suggested change
| onRenderLsp: (filepaths: string[], keywords: string[]) => Promise<Record< | |
| onNavigateSymbol: (filepath: String, symbol: String) => void |
Instead of return SymbolInfo, why not just navigate to the symbol directly?
|
Need handle cases that certain backend doesn't support such feature (e.g IntelliJ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still working
demo
Screen.Recording.2024-11-16.at.14.16.36.mov