Replace Worker with Runner #1233
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1233.test.live.mm.rbg.tum.de in a few minutes. Logins
|
- Actions refined and now with postman, working selfstream requests - A site page development has begun with the needed functionality of heartbeats still in development for the response - the model/runner.go and dao/runner.go have been edited to work better with existing functionalities TODO: - Thumbnail.go still needs tweaking - rest implementations need to be done - having the runners be displayed onto the webpage please text me over element or github if there is anything I forgot to mention in this push
# Conflicts: # runner/actions/stream.go # runner/runner.go
… for the preventions of crashes and fail saves for runners( Jobs.go and Action.go. for now, the notify runner method only looks for streams like the notifyWorker func but I'm working on the overlooking of jobs on tumlive side with the models and dao files I added
* Realised silence detect action * Apply silence detection in the job * align method of setting a new value in the context with existing actions * send silence results to server on success
* Add commands for audio normalization; pass 1 realised in a new action * Pass 1 realised in a new action * Make sure transcoding with audio normalization does the same to video. * Integrate audio normalization into transcode. Apply it only when exactly 1 video exists for the stream. * Pass 1: properly return error message * Pass 1: 1. synchronise reading from stdin before extracting info; 2. make sure to close everything in case of error * Audio normalization: log when applied * Remove the unused action AudioNormalization --------- Co-authored-by: Dawin <[email protected]>
…web page but not fully finished the pop up window. working on the models and their schemas.
This was referenced Sep 23, 2024
Open
This was
linked to
issues
Oct 7, 2024
Open
# Conflicts: # .golangci.yml # cmd/tumlive/tumlive.go # go.work.sum # tools/stream-signing.go # web/admin.go # web/template/partial/footer.gohtml # web/template/user-settings.gohtml
jetzt sollte tumlive auf die richtige vm zugreifen müssen
…usted the cmd.yaml for less clutter during hls stream
# Conflicts: # runner/actions/stream.go
SebiWrn
reviewed
Nov 24, 2024
runner/actions/stream.go
Outdated
|
|
||
| localhls := fmt.Sprintf("%v/%d/%d/%s/%s/playlist.m3u8", hostname, courseID, streamID, version, end.Format("15-04-05")) | ||
|
|
||
| edgeURL, err := url.Parse(fmt.Sprintf("http://%v:8089/%v", |
There was a problem hiding this comment.
Edge Server isn't hosted on Port 8089 when not in development (port needs to be a config option)
There was a problem hiding this comment.
the config option has been added. mind that the port is rn only one port and if needed to have multiple edge servers, we need to think of a selection option to not swarm one server full
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current worker implementation is hard to maintain, we therefore want to replace it with the new runner. The goal is to have a clean code base that replaces everything the worker does.
todos:
Functionality wise, the runner should: