Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description for utilizing the scripts folder #2086

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rorar
Copy link

@rorar rorar commented Oct 8, 2024

Added prerequisites for better understanding the following steps. It should be clearer now that the user needs to create a scripts folder and has to select it inside the settings.

Pull Request

Purpose

Improved information base for lesser-techie users.

Approach

From the user perspective, I had the issue to understand where to put the scripts. I tried to solve this by adding helpful informations and links to the official SABnzbd KB.

Open Questions and Pre-Merge TODOs

Nothing to do here

Requirements

Added prerequisites for better understanding the following steps.
It should be clearer now that the user needs to create a scripts folder and has to select it inside the settings.
@github-actions github-actions bot added Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related labels Oct 8, 2024
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but you still need to fix a few issues before it gets approved. Click on details to see what the issue is that needs to be fixed.

@TRaSH- TRaSH- added Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information and removed Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information labels Oct 8, 2024
Added prerequisites for better understanding the following steps.
It should be clearer now that the user needs to create a scripts folder and has to select it inside the settings.
2nd commit approach. I'm new to this stuff.
Added prerequisites for better understanding the following steps.
It should be clearer now that the user needs to create a scripts folder and has to select it inside the settings.
3rd commit approach. I'm new to this stuff.
@rorar rorar changed the title Update index.md Updated description for utilizing the scripts folder Oct 14, 2024
@rorar
Copy link
Author

rorar commented Oct 14, 2024

Hi @TRaSH-
I'm not familiar with your GitHub automations.
Why is Pull the Request Title Validation / pull-request-title-validation (pull_request) Failing and how can I fix that?

Added prerequisites for better understanding the following steps.
It should be clearer now that the user needs to create a scripts folder and has to select it inside the settings.
4th commit approach. I'm new to this stuff.
@bakerboy448
Copy link
Contributor

PR title must align to the regex
script: const titleRegex = /^(Revert ")?(feat|fix|docs|style|refactor|perf|test|update|build|ci|chore)(([\w/-]+))?:\s.+$/g;

@TRaSH-
Copy link
Contributor

TRaSH- commented Oct 19, 2024

https://github.com/TRaSH-Guides/Guides/blob/master/CONTRIBUTING.md#pull-request-naming

So you will get something like: feat(guides): SABnzbd - Updated description for utilizing the scripts folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants