-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radarr): removed CiNEPHiLES from Remux Tier #1523
base: master
Are you sure you want to change the base?
fix(radarr): removed CiNEPHiLES from Remux Tier #1523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; marking do not merge pending discussions with CiNEPHiLES
After reporting this issue to a CiNEPHiLES member, they said that another member made the mistake by using the wrong release name that didn't match the actual correct filename. example: Why is this wrong?: Solution:
Being this isn't the first occurrence of mismatched naming. We have decided as Team that if we get further reports of wrong release/file names we will draw a line and move them (CINEPHILES) without any further reports to the LQ |
@TRaSH- I think we can close this one off for now? |
…ier-to-prevent-download-loop
…ier-to-prevent-download-loop
Pull Request
Purpose
Removed RlsGrp
CiNEPHiLES
from Remux Tier to prevent download loops.This RlsGrp often sources alternative audio tracks, and adds these to releases alongside modern multichannel audio. Users have reported download loops as the audio format referred to in the release name does not always match the audio format in the filename. TRaSH Guides relies on automation provided by using different scores for different audio formats, so inconsistencies in naming will lead to download loops.
Radarr only probes the first audio track of any file, and cannot read nfo files. Discovery of multiple audio tracks would currently require scraping the tracker or indexer, which is not permitted. If both the release name and the filename do not contain the audio format used for the first audio track in the file, then download loops will result.
This issue is resolvable by the implementation of consistent release and file naming with regards to audio formats.
Approach
Removed RlsGrp
CiNEPHiLES
from Remux Tier and added them to theLQ
Open Questions and Pre-Merge TODOs
Requirements