Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprint and privacy #57

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Imprint and privacy #57

merged 6 commits into from
Aug 11, 2023

Conversation

ChristophNiehoff
Copy link
Contributor

Added possibility to add imprint and privacy notice links.

@ChristophNiehoff ChristophNiehoff force-pushed the imprint_and_privacy branch 2 times, most recently from 5d19565 to 4ae7c0d Compare August 4, 2023 08:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/client/components/board/board.test.tsx Outdated Show resolved Hide resolved
src/client/components/footer/imprint.tsx Outdated Show resolved Hide resolved
src/client/components/footer/privacy.tsx Outdated Show resolved Hide resolved
src/client/pages/__tests__/create.test.tsx Outdated Show resolved Hide resolved
@ChristophNiehoff
Copy link
Contributor Author

ChristophNiehoff commented Aug 11, 2023

@ghost91-
You asked why the line
Board.prototype.componentDidMount = jest.fn();
was needed.

It appears that the Board component performs some REST calls in its componentDidMount hook. This is probably not optimal. As a quickfix I changed it to
Board.prototype.apiGetRequest = jest.fn();

Without this mock, the tests fail in the Github Action. (But not on my local machine....)

@ChristophNiehoff ChristophNiehoff merged commit 55269c6 into master Aug 11, 2023
3 checks passed
ChristophNiehoff added a commit that referenced this pull request Aug 14, 2023
Signed-off-by: Christoph Niehoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants