Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page to draw random cards #135

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

New page to draw random cards #135

wants to merge 8 commits into from

Conversation

ChristophNiehoff
Copy link
Contributor

No description provided.

ghost91-
ghost91- requested changes Nov 15, 2024
View reviewed changes
apps/client/src/pages/random-card.tsx Outdated Show resolved Hide resolved
apps/client/src/components/randomcarddisplay/randomCardDisplay.tsx Show resolved Hide resolved
apps/client/src/components/randomcarddisplay/randomCardDisplay.tsx Outdated Show resolved Hide resolved
apps/client/src/components/randomcarddisplay/randomCardDisplay.tsx Outdated Show resolved Hide resolved
apps/client/src/components/randomcarddisplay/randomCardDisplay.tsx Outdated Show resolved Hide resolved
apps/client/src/pages/random-card.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to include some way to navigate back to the create page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens when clicking the EoP logo. For me, that is enough.

apps/client/src/pages/create.tsx Outdated Show resolved Hide resolved
apps/client/src/pages/create.tsx Outdated Show resolved Hide resolved
@ChristophNiehoff
Added new page for drawing a random card
cf3b837 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
bump version
98e0d02 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
Remove Helmet from random-card page
a9c869a 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
refactor onclick handler
41d052e 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
Address review comments
3916679 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
Fix alignment of dealt card
903cc84 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
make logo clickable
c77ff99 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
fix linting
c9b9b15 
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff
Copy link
Contributor Author

ChristophNiehoff commented Nov 19, 2024 •
edited
Loading

@ghost91- I addressed your comments.
However, #137 introduced a "bug": Via the global CSS'ing now every background was black (also when playing the game).
Instead of fixing all the global CSS, I took this as an opportunity, to make the background white everywhere (as personally I am not a big fan of dark mode 🙈 ). What do you think?

(current version is deployed to staging env.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghost91- ghost91- ghost91- requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophNiehoff @ghost91-