Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from olofk:master #118

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

[pull] master from olofk:master #118

wants to merge 64 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 12, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jun 12, 2022
shareefj and others added 12 commits June 17, 2022 21:19
Verilator builds previously used all available CPUs by calling Make with the -j<cpu_count>
argument. This is fine when running on your local machine but is not fine when running the
build in a professional environment where you are submitting the job to a cluster.

This update removes the -j<cpu_count> argument from the build step.  Users wishing to use
N CPUs for a build should instead pass the MAKEFLAGS environment variable when calling
fusesoc:

  export MAKEFLAGS=-jN; fusesoc ...
edalize_common is a helper module that contains the asserts used
in most tests. pytest however normally only support asserts used
in the actual test module.

This patch adds an __init__.py for the tests that enables pytest
asserts in edalize_common, together with related changes.
Before this change, there was no meaningful way to use flow options
because it was not possible to query or set tool options for tools
outside of the ones in the static FLOW list.

This patch separates the process of applying options into two steps.
A user can first use get_flow_options to get flow options and then
use get_tool_options with the preferred flow options set, to get
all tool options for a configured flow.

The redefinition of get_flow_options to only return flow options
(and not also tool options like previously) is an API break but will
hopefully not cause too much trouble.
olofk and others added 15 commits December 15, 2022 22:16
test_edam_hooks is supposed to exit with error code 1, and the test
is looking for this. For some reason, the error code becomes 2 when
running through CI which makes the test fail.

Instead of finding the root cause, we just relax the requirement to
allow exits with any error code.
This fix the issue where `f"{self.name}.{output_format}"` is always used
as a target name in the Makefile even if the custom output name is
defined in the tool options.
@olofk olofk deleted the branch SymbiFlow:master January 19, 2023 21:17
@olofk olofk deleted the master branch January 19, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.