Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invokable to make sure container linter works #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix invokable to make sure container linter works #11

wants to merge 3 commits into from

Conversation

bashilbers
Copy link

Hey, I created this fix to make sure the container linter is able to lint it. These missing __invoke methods made the lint:container command fail.

Zales0123
Zales0123 reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but it would be great to have these new methods tested in this and this tests 🖖

@bashilbers
Copy link
Author

Hey @Zales0123 I added the tests

@bashilbers
Copy link
Author

@GSadee can u merge?

@lchrusciel
Copy link
Member

Hey Sebastian!

thanks a lot for your contribution! I'm open to merge your PR, but can you elaborate a little bit more why is it needed? In Sylius we have this lib and the container seems to be ok:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bashilbers @lchrusciel @GSadee @Zales0123