Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing type definitions #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LitoMore
Copy link

The image data that I got from the client.getGridsById(gameId) returns the data in the format below:

{
  id: 484680,
  score: 0,
  style: 'alternate',
  width: 600,
  height: 900,
  nsfw: false,
  humor: false,
  notes: null,
  mime: 'image/png',
  language: 'en',
  url: 'https://cdn2.steamgriddb.com/grid/57bc9596033a61dba1c4df9a1c728d61.png',
  thumb: 'https://cdn2.steamgriddb.com/thumb/57bc9596033a61dba1c4df9a1c728d61.jpg',
  lock: false,
  epilepsy: false,
  upvotes: 0,
  downvotes: 0,
  author: {
    name: 'ABH20',
    steam64: '76561198058544946',
    avatar: 'https://avatars.steamstatic.com/378a48fc2172839e4ca7589e1d6bb235691714fa_medium.jpg'
  }
}

Do I need to update those tests for the new data structure?

And are tags and language still needed? Can I remove them from the type definition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant