update documentation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
markus-hentsch
requested changes
Aug 6, 2024
|
Sorry since you added me as a reviewer, I started reviewing before you pushed the latest changes, so some things might not be applicable anymore. I will check again. |
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Don't worry, my fault. :-) |
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
|
@markus-hentsch Thanks for your precise review as well as your suggestions. I update README. Please have a second look. |
markus-hentsch
requested changes
Aug 8, 2024
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: anjastrunk <[email protected]>
Minimum allowed line rate is |
markus-hentsch
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation according to #4 (comment).
closes to #4