✨ add new builder image approach and update dependencies #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschoone
added
the
Container
|
For testing, The following make targets run inside the container. make lint-yaml
make lint-yaml-ci
make format-yaml
make lint-links
make lint-dockerfile
make lint-golang
make lint-golang-ci
make format-golang
make generate-modules |
batistein
approved these changes
Feb 28, 2024
kranurag7
force-pushed
the
kr/add-builder-image
branch
2 times, most recently
from
6e6fa7e
to
a8ed7f3
Compare
Signed-off-by: kranurag7 <[email protected]> update release workflow as per new builder image Signed-off-by: kranurag7 <[email protected]> fix linting error and add lychee Signed-off-by: kranurag7 <[email protected]> update builder image to 1.1.0 and include helm Signed-off-by: kranurag7 <[email protected]> update release workflow as per new builder image Signed-off-by: kranurag7 <[email protected]> fix linting error and add lychee Signed-off-by: kranurag7 <[email protected]>
kranurag7
force-pushed
the
kr/add-builder-image
branch
from
a8ed7f3
to
0ce9c29
Compare
we always use the image by version and propogating latest tag is not required. Signed-off-by: kranurag7 <[email protected]>
kranurag7
added a commit
that referenced
this pull request
Apr 24, 2024
✨ add new builder image approach and update dependencies
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #76
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: