Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 create github client only if required #67

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

kranurag7
Copy link
Contributor

create github client only when required.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

in this case, it's only created if download is true

Signed-off-by: kranurag7 <[email protected]>
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janiskemper janiskemper marked this pull request as ready for review February 15, 2024 17:07
@kranurag7 kranurag7 changed the title 🌱 create github client only only if required 🌱 create github client only if required Feb 15, 2024
@kranurag7 kranurag7 merged commit c7b714d into main Feb 15, 2024
10 checks passed
@kranurag7 kranurag7 deleted the syself/github-client-fix branch February 15, 2024 17:43
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
kranurag7 added a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GitHub client only if it is necessary
4 participants