Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQ Plugin: Remove usages of deprecated Build.setProfile in the integration tests #9563

Merged
merged 2 commits into from
Jul 30, 2024
Merged

SQ Plugin: Remove usages of deprecated Build.setProfile in the integration tests #9563

merged 2 commits into from
Jul 30, 2024

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Jul 25, 2024 •
edited
Loading

Fixes #3102

I removed them all and the tests do not fail.

@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft July 25, 2024 14:42
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Replace usages of deprecated Build.setProfile in the integration tests Remove usages of deprecated Build.setProfile in the integration tests Jul 25, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as ready for review July 25, 2024 15:43
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Remove usages of deprecated Build.setProfile in the integration tests SQ Plugin: Remove usages of deprecated Build.setProfile in the integration tests Jul 26, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/setProfile branch 2 times, most recently from 3d8c90c to 9c71fed Compare July 26, 2024 07:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Tim-Pohlmann Tim-Pohlmann requested review from Tim-Pohlmann and removed request for zsolt-kolbay-sonarsource July 29, 2024 13:39
Tim-Pohlmann
Tim-Pohlmann approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked the IT run times and they did not explode, so I'm in favor of dropping the profile entirely for simplicity.
Please double check that we have ITs that do check that quality profiles work, though.

@mary-georgiou-sonarsource
Copy link
Contributor Author

Performance wise seems the same if not even faster.
For the tests - if more are needed let's discuss and add them in a separate PR.

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit e3deb5d into master Jul 30, 2024
21 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/setProfile branch July 30, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQ Plugin: Replace usages of deprecated Build.setProfile in the integration tests
2 participants
@mary-georgiou-sonarsource @Tim-Pohlmann