Fix S1854 FP: Value used after catch #9531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/fp-after-catch
branch
from
2b83ac1
to
c2880fa
Compare
Tim-Pohlmann
requested changes
Jul 18, 2024
| @@ -124,7 +125,7 @@ private void BuildBranches(BasicBlock block) | |||
| if (block.EnclosingNonLocalLifetimeRegion() is { Kind: ControlFlowRegionKind.Try } tryRegion) | |||
| { | |||
| var catchesAll = false; | |||
| foreach (var catchOrFilterRegion in block.Successors.SelectMany(CatchOrFilterRegions)) | |||
| foreach (var catchOrFilterRegion in block.Successors.Union(Cfg.Blocks[tryRegion.LastBlockOrdinal].Successors).SelectMany(CatchOrFilterRegions)) | |||
There was a problem hiding this comment.
For me this approach looks more natural:
Suggested change
| foreach (var catchOrFilterRegion in block.Successors.Union(Cfg.Blocks[tryRegion.LastBlockOrdinal].Successors).SelectMany(CatchOrFilterRegions)) | |
| foreach (var catchOrFilterRegion in CatchOrFilterRegions(tryRegion.EnclosingRegion(ControlFlowRegionKind.TryAndCatch))) |
This is only to show the idea, the implementation needs to be a bit different (this currently throws in a using statement). But the idea would be for every block to look at the enclosing try-catch region and add branches to all catch regions.
There was a problem hiding this comment.
I don't understand.
I need the leaving regions of the try region.
mary-georgiou-sonarsource
force-pushed
the
mary/fp-after-catch
branch
4 times, most recently
from
7a275bd
to
ff769a1
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/fp-after-catch
branch
from
eec2cf3
to
7e21ddd
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9467