Fix S2259 FP: SE engine doesn't take into account element existence collection methods #9505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/se-fp
branch
3 times, most recently
from
f19c0eb
to
a308ece
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/se-fp
branch
from
4d270cc
to
11777a0
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/se-fp
branch
from
11777a0
to
ba04919
Compare
Comment on lines
142
to
146
| symbol.IsExtensionMethod switch | ||
| { | ||
| true => symbol.Parameters.Length > 1, | ||
| false => !symbol.Parameters.IsEmpty | ||
| }; |
There was a problem hiding this comment.
Suggested change
| symbol.IsExtensionMethod switch | |
| { | |
| true => symbol.Parameters.Length > 1, | |
| false => !symbol.Parameters.IsEmpty | |
| }; | |
| symbol.IsExtensionMethod | |
| ? symbol.Parameters.Length > 1 | |
| : !symbol.Parameters.IsEmpty; |
zsolt-kolbay-sonarsource
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
LGTM (review was mostly done sync with @mary-georgiou-sonarsource and @Tim-Pohlmann)
mary-georgiou-sonarsource
force-pushed
the
mary/se-fp
branch
from
61234cf
to
11c153d
Compare
|
|
| Tag("Value", value); | ||
| """; | ||
| var validator = SETestContext.CreateCS(code, $"List<object> collection").Validator; | ||
| validator.TagValue("Value").Should().HaveOnlyConstraint(ObjectConstraint.Null); |
There was a problem hiding this comment.
You can merge these tests into one if you extract the collection type into a parameter:
"List<object>""Dictionary<int, object>"- etc.
There was a problem hiding this comment.
yes but I'm testing different things - in one case it's a reference that can return null and in the other case it never returns cause the keyvalue pair is a struct.
mary-georgiou-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8266