S1854: Add FP repro for #9466, #9467, #9468 #9469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
mary-georgiou-sonarsource
approved these changes
Jun 27, 2024
Comment on lines
+1556
to
+1558
| catch (Exception exc) | ||
| { | ||
| } |
There was a problem hiding this comment.
Slightly more ecological.
Suggested change
| catch (Exception exc) | |
| { | |
| } | |
| catch (Exception ex) { } |
There was a problem hiding this comment.
While I'd normally do that, in this case, the catch has significant impact on the flow so I wanted to waste a bit of space on it.
Comment on lines
+1575
to
+1577
| catch (Exception exc) | ||
| { | ||
| } |
There was a problem hiding this comment.
Suggested change
| catch (Exception exc) | |
| { | |
| } | |
| catch (Exception ex) { } |
Comment on lines
+1607
to
+1611
| try | ||
| { | ||
| try | ||
| { | ||
| CanThrow(); |
There was a problem hiding this comment.
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduces #9466, #9467, #9468