Fix S1144 FP: Nested types decorated with StructLayout attribute #9441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S1144-FP-nested-StructLayout
branch
from
b1ec68c
to
8820b50
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S1144-FP-nested-StructLayout
branch
from
0d9fc26
to
36a5bf5
Compare
| @@ -54,18 +54,6 @@ | |||
| "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/akka.net/src/core/Akka/Event/DeadLetterListener.cs#L255", | |||
| "Location": "Line 255 Position 29-37" | |||
| }, | |||
| { | |||
| "Id": "S1144", | |||
There was a problem hiding this comment.
Both are FPs: private readonly fields inside a type marked with the StructLayout attribute.
|
|
mary-georgiou-sonarsource
deleted the
Zsolt/fix-S1144-FP-nested-StructLayout
branch
|
Peach validation was successful: ~50 FP cases were eliminated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9432