Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1144 FP: Private attributes #9411

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Fix S1144 FP: Private attributes #9411

merged 7 commits into from
Jun 13, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #8342

martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symbol.ContainingAssembly.Equals(compilation.Assembly)) check can be removed.

martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change: Correct the tile of the issue before merging:
#8342

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from Zsolt/Fix-S1144-FP-reflection to master June 13, 2024 12:43
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource marked this pull request as ready for review June 13, 2024 13:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit e9c56ca into master Jun 13, 2024
26 checks passed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the Zsolt/Fix-S1144-FP-private-attribute branch June 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S1144 FP: Private Attributes
3 participants
@zsolt-kolbay-sonarsource @martin-strecker-sonarsource @CristianAmbrosini